Skip to content

[Fix] user_onboardings 운동 유형 제약 조건 현행화#154

Merged
pooreumjung merged 2 commits into
developfrom
fix/#152-user-onboarding-exercise-type-constraint
May 29, 2026
Merged

[Fix] user_onboardings 운동 유형 제약 조건 현행화#154
pooreumjung merged 2 commits into
developfrom
fix/#152-user-onboarding-exercise-type-constraint

Conversation

@pooreumjung

Copy link
Copy Markdown
Member

🧾 요약

  • user_onboardings 테이블의 exercise_type CHECK 제약을 현재 ExerciseType enum 값과 일치하도록 수정

🔗 이슈

✨ 변경 내용

  • V25 마이그레이션 추가: 기존 레거시 enum 값(CARDIO, PILATES, YOGA,
    WALKING_HIKING)을 현행 enum(WALKING, RUNNING, PILATES_YOGA, HIKING)으로 데이터 변환
  • 기존 CHECK 제약 DROP 후 현행 ExerciseType 전체 값 기준으로 재설정

✅ 확인

  • 빌드 OK
  • 테스트 OK

@pooreumjung pooreumjung self-assigned this May 29, 2026
@pooreumjung pooreumjung added the bug Something isn't working label May 29, 2026
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e5a0c70a-3905-4486-99d8-bb7957561811

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#152-user-onboarding-exercise-type-constraint

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

본 PR은 데이터베이스의 운동 유형 제약 조건을 현재 애플리케이션의 ExerciseType enum 정의와 일치시키기 위한 마이그레이션 작업을 수행합니다. 이를 통해 데이터 무결성을 확보하고 향후 데이터 저장 시 발생할 수 있는 제약 조건 위반 오류를 방지합니다.

Highlights

  • 데이터 마이그레이션: 기존 레거시 운동 유형 데이터(CARDIO, PILATES, YOGA, WALKING_HIKING)를 현재 시스템의 enum 값(WALKING, RUNNING, PILATES_YOGA, HIKING)으로 변환하는 SQL을 추가했습니다.
  • DB 제약 조건 현행화: user_onboardings 테이블의 exercise_type CHECK 제약을 삭제하고, 최신 ExerciseType enum 값들을 모두 포함하도록 새롭게 정의했습니다.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a database migration script (V25__update_user_onboarding_exercise_type_check.sql) to update the exercise_type values in the user_onboardings table and align the CHECK constraint with the current ExerciseType enum. A critical issue was identified where the migration could fail because the UPDATE statements are executed while the old constraint is still active, which does not allow the new enum values. The feedback suggests dropping the constraint before performing the updates to prevent migration failure.

@pooreumjung
pooreumjung merged commit 16aa4d1 into develop May 29, 2026
1 check passed
@howooyeon
howooyeon deleted the fix/#152-user-onboarding-exercise-type-constraint branch June 3, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] user_onboarding check 제약 불일치 해결

1 participant